Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deactive guard for pop up the warning box before leaving the current page when forms have unsaved info #476

Merged
merged 6 commits into from
Feb 2, 2025

Conversation

yzlucas
Copy link
Collaborator

@yzlucas yzlucas commented Jan 31, 2025

No description provided.

@yzlucas yzlucas requested review from ssylver93 and dhlevi January 31, 2025 22:05
ssylver93
ssylver93 previously approved these changes Jan 31, 2025
Copy link
Contributor

@dhlevi dhlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the canDeactivate logic? Looks like it might need a tweak to understand undefined/null/false

@yzlucas yzlucas requested a review from dhlevi February 1, 2025 01:05
@yzlucas yzlucas merged commit 71e1786 into main Feb 2, 2025
7 checks passed
@yzlucas yzlucas deleted the leaving-page-unsaved-guard branch February 2, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants