WFPREV-259 Change project entity to use ObjectiveTypeCodeModel for JPA #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ssylver93
commented
Jan 17, 2025
ssylver93
commented
- Change project entity to use ObjectiveTypeCodeModel
- Fix bug with existing entity code values being set for project update
- Github actions CI/CD change to run latest liquibase changes on build
…eature/WFPREV-259
…eature/WFPREV-259
…eature/WFPREV-259
…eature/WFPREV-259
| import ca.bc.gov.nrs.wfprev.data.models.GeneralScopeCodeModel; | ||
| import ca.bc.gov.nrs.wfprev.data.models.ProjectModel; | ||
| import ca.bc.gov.nrs.wfprev.data.models.ProjectTypeCodeModel; | ||
| import ca.bc.gov.nrs.wfprev.data.entities.*; |
There was a problem hiding this comment.
we generally want to avoid wildcard imports (I think I've been guilty of doing this myself). I'm beting your intellij setting is doing this. YOu can turn up the number of imports much higher than the default that it allows before it starts converting to use imports.
agordon-vivid
approved these changes
Jan 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.