Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting the update and create logic in the project service to reduce complexity #380

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Splitting the update and create logic in the project service to reduce complexity #380

merged 4 commits into from
Dec 19, 2024

Conversation

agordon-vivid
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dhlevi
dhlevi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dhlevi dhlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here I thought having a createOrUpdate reduced complexity. Not in all cases :)

@agordon-vivid
Copy link
Contributor Author

And here I thought having a createOrUpdate reduced complexity. Not in all cases :)

hehe. We still have it ostensibly but it's moved to the saveProject() method with the specific logic required for create and update separated out.

@agordon-vivid agordon-vivid merged commit 774cdc1 into main Dec 19, 2024
7 checks passed
@agordon-vivid agordon-vivid deleted the split-update-logic branch December 19, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhlevi dhlevi dhlevi approved these changes

@yzlucas yzlucas yzlucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agordon-vivid @dhlevi @yzlucas