Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination and sort order functionality to searchobject endpoint #232

Closed
wants to merge 2 commits into from
Closed

Add pagination and sort order functionality to searchobject endpoint #232

wants to merge 2 commits into from

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Dec 9, 2023 •
edited
Loading

  • Test using all five and individual query parameters (page=1&permissions=y&limit=3&sort=name&order=desc)
  • Make sure key(X-Total-Rows) is present in header and updated with each request (with or without pagination)
  • Test using Basic and JWT authentications
  • Confirm all relevant permissions are being fetched

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jatindersingh93 jatindersingh93 force-pushed the SC3444 branch 9 times, most recently from 57cb46d to 4d68a69 Compare December 15, 2023 15:50
@jatindersingh93 jatindersingh93 marked this pull request as ready for review December 15, 2023 16:58
@TimCsaky TimCsaky deleted the SC3444 branch January 22, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jujaga jujaga Awaiting requested review from jujaga

@norrisng-bc norrisng-bc Awaiting requested review from norrisng-bc norrisng-bc is a code owner

@TimCsaky TimCsaky Awaiting requested review from TimCsaky TimCsaky is a code owner

@wilwong89 wilwong89 Awaiting requested review from wilwong89

@kyle1morel kyle1morel Awaiting requested review from kyle1morel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatindersingh93 @TimCsaky