Updated how API is called so it can support both client-side and server-side calls in a secure way #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-side calls in a secure way
brysonjbest
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to have an exposed API endpoint.
The issue was that Nextjs can make both client-side and server-side requests. The server side requests couldn't make use of the Keycloak credentials so they required an open API endpoint.
With this change the server-side requests can use the OpenShift service directly like
http://brms-api:3000/apiand the client side can use just/apiwith its Keycloak credentials.I also update the Nextjs config to be inline with our OpenShift deployment that has the API accessible to the frontend at
apiNote: I skipped the usual process and already merged this into dev because I wasn't sure if it would work or not.