Feature/editing iterative improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timwekkenbc
commented
Aug 12, 2024
timwekkenbc
commented
- Renamed and reorganized components to be easier to understand
- Directly navigate to rule manager page so there is no delay on load
- Rename main page
- Update header to be properly responsive
- Fix issue where rule with long json name bugs out sending it for review
- Add check to make sure inputed file path/name somewhat valid and is json when creating a new rule
- Show "bulk scenarios" for inReview and Published (but not embedded)
- Fix issue with linked rules not showing up properly anymore
- Fix issues with being able to change linked rule when not in edit mode
…ng json name bugs out sending it for review, Add check to make sure inputed file path/name somewhat valid and is json when creating a new rule, Show "bulk scenarios" for inReview and Published (but not embedded), Fix issue with linked rules not showing up properly anymore, Fix issues with being able to change linked rule when not in edit mode
…ly navigate to rule manager page so there is no delay on load, Rename main page
brysonjbest
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Really happy with this being refactored into its own component.
| @@ -44,7 +44,22 @@ export default function NewRule() { | |||
| <Form.Item | |||
| label="File path/name" | |||
| name="goRulesJSONFilename" | |||
| rules={[{ required: true, message: "Please input your JSON file path!" }]} | |||
| rules={[ | |||
There was a problem hiding this comment.
Great clarification for the naming requirements. The active validation is so great! Would additional helper text indicating the formatting requirements ahead of time also be helpful? Something like:
help="example: my-rule.json or my-path/my-rule.json"
There was a problem hiding this comment.
Yeah, good idea. For some reason the "help" parameter overrides any error messages, so I'm going to add it as a tooltip because that's easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.