Hydration errors 2 #191
Merged
Hydration errors 2 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorwolpert
approved these changes
Oct 19, 2024
| @@ -73,6 +75,13 @@ const { data: pprSections } = await useAsyncData(`ppr-sections-${locale.value}`, | |||
| return queryContent().where({ _locale: locale.value, _path: { $contains: 'ppr/sections' } }).find() | |||
| }) | |||
|
|
|||
| // srr safe media query | |||
| watchDebounced(width, () => { | |||
There was a problem hiding this comment.
interesting, for hydration issues?
There was a problem hiding this comment.
Yes, initial render the ref is false on server and true on client so it causes a mismatch. This way the value is the same for server/client and still updates when the screen width changes, used debounced watcher to update once the screen width ref changes and to not fire multiple events if the screen changes width after mount.
|
@deetz99 I've deployed main back to dev.. there are some 404 screens we keep seeing with login and logout
|
|
Clicking here for example:
|
|
Okay thanks, I'll need to add in the login/logout redirects then. Do you know if the signin/bceid, signin/bcsc and signin/bceid are in use at all ? |
|
Yes they all are |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed order of bg images on ppr marketing page causing hydration errors