Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add env vars and i18n translations #184

Merged
merged 18 commits into from
Sep 22, 2024
Merged

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Sep 22, 2024

  • lots of files but only adding in translations and using env vars instead of hardcoded links
  • add back in .github files
  • update env.sample and vaults.env

Only 2 changes outside of i18n and config:

  1. I've updated the product card component to have an href that can be resolved from the runtime config or hardcoded or set with the locale or have the account id appended
  2. change sbc auth menu component to use the loggedoutuseroptions provided by the core layer

@deetz99 deetz99 added the enhancement New feature or request label Sep 22, 2024
@deetz99 deetz99 requested a review from thorwolpert September 22, 2024 04:00
@deetz99 deetz99 self-assigned this Sep 22, 2024
@thorwolpert thorwolpert merged commit a696879 into bcgov:v2 Sep 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants