Replace table role with treegird for screenreader #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
Code Climate has analyzed commit 80b1132 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 28.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.5% (-0.1% change). View more on Code Climate. |
When adding or removing permissions for a bucket/object, a call is made to fetch permissions immediately after. This call was not scoped at all, so it would fetch permissions for ALL buckets/objects, resulting in a very heavy COMS API call. This has now been restricted to just the bucket/object being updated.
When adding or removing permissions for a bucket/object, a call is made to fetch permissions immediately after. This call was not scoped at all, so it would fetch permissions for ALL buckets/objects, resulting in a very heavy COMS API call. This has now been restricted to just the bucket/object being updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC3689
Description
Types of changes
Checklist
Further comments