Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkboxes after Primevue update #189

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

  • After the PrimeVue update, the emits for checkbox component have changed. @input doesnt seem to work anymore.
  • css class changes to input elements

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@TimCsaky TimCsaky requested review from jatindersingh93 and removed request for jatindersingh93 April 30, 2024 23:48
Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit 2a72613 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.5% (0.0% change).

View more on Code Climate.

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 19.33% ( 699 / 3616 )
Methods: 18.5% ( 133 / 719 )
Lines: 23.21% ( 487 / 2098 )
Branches: 9.89% ( 79 / 799 )

css class changes to input elements
@jatindersingh93 jatindersingh93 merged commit 6aeda1b into master May 1, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the checkbox-fix branch May 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants