Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permCodes and checkbox options #187

Merged
merged 2 commits into from
May 1, 2024
Merged

Add permCodes and checkbox options #187

merged 2 commits into from
May 1, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Apr 25, 2024

  • add READ, UPDATE, CREATE Checkbox permissions to bucket invite links
  • Add READ, UPDATE checkbox permissions to files invite links
  • READ is default

SHOWCASE-3643

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Apr 25, 2024

Code Climate has analyzed commit c3ebc22 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 16.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.5% (0.0% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 force-pushed the SC3643 branch 2 times, most recently from 890c38d to 8f806e3 Compare April 29, 2024 20:00
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Apr 29, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.28% ( 702 / 3641 )
Methods: 18.56% ( 134 / 722 )
Lines: 23.18% ( 489 / 2110 )
Branches: 9.77% ( 79 / 809 )

@jatindersingh93 jatindersingh93 marked this pull request as ready for review April 30, 2024 22:36
@TimCsaky TimCsaky merged commit 5d037d6 into master May 1, 2024
18 of 19 checks passed
@jatindersingh93 jatindersingh93 deleted the SC3643 branch May 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants