Show correct file upload status #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
TimCsaky
force-pushed
the
bug/upload-complete
branch
from
3700a14 to
feebcc2
Compare
Coverage Report (Frontend)
|
|
Code Climate has analyzed commit 215b7da and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 20.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.5% (0.0% change). View more on Code Climate. |
TimCsaky
requested review from
kyle1morel,
wilwong89,
jatindersingh93 and
norrisng-bc
as code owners
Catch COMS error and show toast at component level Simplify fileUpload template
TimCsaky
force-pushed
the
bug/upload-complete
branch
from
feebcc2 to
5ad82a3
Compare
jatindersingh93
approved these changes
Apr 5, 2024
TimCsaky
force-pushed
the
bug/upload-complete
branch
2 times, most recently
from
18d78ba to
0700f6a
Compare
TimCsaky
force-pushed
the
bug/upload-complete
branch
from
0700f6a to
215b7da
Compare
norrisng-bc
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3549
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments