Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3508
Description
Caused by the browser settings relating to pop-ups and new tabs.
mdn docs:
Modern browsers have strict popup blocker policies. Popup windows must be opened in direct response to user input, and a separate user gesture event is required for each Window.open() call.
So my proposed change is to show a toast message (in case user has permanantly blocked popups and arent aware of the cause). To allow for this, the window.open() is now invoked in the component.
commits:
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments