Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub-folder creation support #150

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Add sub-folder creation support #150

merged 6 commits into from
Dec 18, 2023

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Dec 7, 2023 •
edited
Loading

Description

BCBox UI for adding a sub-folder to a bucket.
ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3371
ui/ux reference: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3326 (contains link to a mural board)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Coverage Report (Frontend)

Totals Coverage
Statements: 31.63% ( 600 / 1897 )
Methods: 28.96% ( 117 / 404 )
Lines: 38.32% ( 428 / 1117 )
Branches: 14.63% ( 55 / 376 )

@TimCsaky TimCsaky changed the title WIP: UI for creating a sub-folder UI for creating a sub-folder Dec 12, 2023
@TimCsaky TimCsaky marked this pull request as ready for review December 12, 2023 22:18
@jujaga jujaga changed the title UI for creating a sub-folder Add sub-folder creation support Dec 14, 2023
@TimCsaky TimCsaky force-pushed the sub branch 2 times, most recently from 07c1988 to 6013198 Compare December 15, 2023 22:26
@kyle1morel kyle1morel merged commit 096b9f4 into master Dec 18, 2023
18 checks passed
@kyle1morel kyle1morel deleted the sub branch December 18, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norrisng-bc norrisng-bc norrisng-bc left review comments

@jujaga jujaga jujaga approved these changes

@jatindersingh93 jatindersingh93 jatindersingh93 approved these changes

@kyle1morel kyle1morel kyle1morel approved these changes

@wilwong89 wilwong89 Awaiting requested review from wilwong89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimCsaky @jujaga @jatindersingh93 @norrisng-bc @kyle1morel