Add clarification to version update action for non-versioned buckets #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
jatindersingh93
force-pushed
the
SC3378
branch
from
e25cbc1 to
34b1f0d
Compare
Coverage Report (Frontend)
|
jatindersingh93
requested review from
jujaga,
kyle1morel,
TimCsaky,
wilwong89 and
norrisng-bc
as code owners
jujaga
approved these changes
Nov 17, 2023
jatindersingh93
changed the title
jatindersingh93
force-pushed
the
SC3378
branch
from
34b1f0d to
dfa3451
Compare
TimCsaky
reviewed
Nov 17, 2023
| @@ -126,7 +126,9 @@ export const useVersionStore = defineStore('version', () => { | |||
| function findVersionsByObjectId(objectId: string) { | |||
| return state.versions.value.filter((x: Version) => x.objectId === objectId); | |||
| } | |||
|
|
|||
| function findS3VersionByObjectId(objectId: string) { | |||
There was a problem hiding this comment.
this is fine. but for future reference, findObjectById() already returns the s3VersionId.
so i think you can do formData.value.s3VersionId
TimCsaky
approved these changes
Nov 17, 2023
jatindersingh93
force-pushed
the
SC3378
branch
from
dfa3451 to
04e751f
Compare
and logic to provide confirm message
jatindersingh93
force-pushed
the
SC3378
branch
from
04e751f to
69bfe78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will display a confirmation pop up when a user tries to upload a non-version bucket file, notifying that action will replace the file and previous version will no longer be available.
Description
Types of changes
Checklist
Further comments