Implement support for nested buckets view #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
kyle1morel
force-pushed
the
feature/treetable
branch
5 times, most recently
from
015e360 to
331e33c
Compare
kyle1morel
requested review from
jujaga,
TimCsaky,
wilwong89,
jatindersingh93 and
norrisng-bc
as code owners
kyle1morel
force-pushed
the
feature/treetable
branch
from
848f03d to
86fcec3
Compare
kyle1morel
changed the title
jujaga
reviewed
Nov 17, 2023
kyle1morel
force-pushed
the
feature/treetable
branch
2 times, most recently
from
bbe390c to
c45cd10
Compare
jujaga
approved these changes
Nov 17, 2023
kyle1morel
force-pushed
the
feature/treetable
branch
from
c45cd10 to
bc7bb2a
Compare
TimCsaky
approved these changes
Nov 18, 2023
norrisng-bc
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the bucket list view to use a TreeTable instead of a DataTable. This allows us to mimic a folder hierarchy of buckets based on their canonical path (endpoint, bucket, key). Fake folders will be inserted to create a full tree if there is no direct parent bucket available.
This PR also slipstream resolves a build issue with the Dockerfile.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
Further comments