change some types for getters

bcgov · Mar 11, 2024 · 4eefcb4 · 4eefcb4
1 parent 91d87b4
commit 4eefcb4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/frontend/src/components/object/ObjectFileDetails.vue b/frontend/src/components/object/ObjectFileDetails.vue
@@ -78,14 +78,13 @@ async function onVersionsChanged() {
 
 onMounted(async () => {
   const head = await objectStore.headObject(props.objectId);
-  const isPublic = head?.status === 204;
 
   await permissionStore.fetchBucketPermissions({ userId: getUserId.value, objectPerms: true });
   await objectStore.fetchObjects({ objectId: props.objectId, userId: getUserId.value, bucketPerms: true });
   object.value = getObject.value(props.objectId);
   const bucketId = object.value?.bucketId;
   if (
-    !isPublic &&
+    head?.status !== 204 &&
     (!object.value ||
       !permissionStore.isObjectActionAllowed(object.value.id, getUserId.value, Permissions.READ, object.value.bucketId))
   ) {

diff --git a/frontend/src/components/object/ObjectVersion.vue b/frontend/src/components/object/ObjectVersion.vue
@@ -38,7 +38,7 @@ const { getVersionsByObjectId } = storeToRefs(versionStore);
 
 // State
 const versionId = defineModel<string>('versionId');
-const versions: Ref<Array<Version>> = computed((): any => getVersionsByObjectId.value(props.objectId));
+const versions: Ref<Array<Version>> = computed(() => getVersionsByObjectId.value(props.objectId));
 const tableData: Ref<Array<VersionDataSource>> = computed(() => {
   return versions.value.map((v: Version, index, arr) => ({
     ...v,
@@ -58,8 +58,8 @@ const onVersionClick = (e: any) => {
   versionId.value = e.data.id;
 };
 
-watch(props, async () => {
-  await userStore.fetchUsers({ userId: versions.value.map((x: Version) => x.createdBy) });
+watch(props, () => {
+  userStore.fetchUsers({ userId: versions.value.map((x: Version) => x.createdBy) });
 });
 </script>
 

diff --git a/frontend/src/store/userStore.ts b/frontend/src/store/userStore.ts
@@ -36,7 +36,7 @@ export const useUserStore = defineStore('user', () => {
       () => (userId: string | undefined) => state.userSearch.value.find((x: User) => userId === x.userId)
     ),
     // returns an array of Users corresponding to provided user IDs
-    getUsers: computed(() => (userIds: Array<string> | undefined) => {
+    getUsers: computed(() => (userIds?: Array<string>) => {
       if (userIds && userIds.length) {
         return state.userSearch.value.filter((x: User) => {
           return userIds.includes(x.userId);