Test coverage

bcgov · Nov 9, 2023 · 83e15f6 · 83e15f6
1 parent a6b9e6b
commit 83e15f6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/...est/java/ca/bc/gov/educ/grad/report/api/test/service/GradReportApiSchoolServiceTests.java b/...est/java/ca/bc/gov/educ/grad/report/api/test/service/GradReportApiSchoolServiceTests.java
@@ -85,7 +85,6 @@ public void createSchoolDistributionReportException() throws Exception {
 		LOG.debug("<{}.createSchoolDistributionReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/schoolDistributionReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getSchoolDistributionReport(reportRequest);
@@ -131,7 +130,6 @@ public void createDistrictDistributionYearEndReportException() throws Exception
 		LOG.debug("<{}.createDistrictDistributionYearEndReport at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/districtDistributionYearEndReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getDistrictDistributionReportYearEnd(reportRequest);
@@ -178,7 +176,6 @@ public void createDistrictDistributionYearEndNonGradReportException() throws Exc
 		LOG.debug("<{}.createDistrictDistributionYearEndNonGradReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/districtDistributionYearEndNonGradReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getDistrictDistributionReportYearEndNonGrad(reportRequest);
@@ -301,7 +298,6 @@ public void createSchoolLabelReportException() throws Exception {
 		LOG.debug("<{}.createSchoolLabelReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/schoolLabelReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getSchoolLabelReport(reportRequest);
@@ -341,7 +337,6 @@ public void createSchoolGraduationReportException() throws Exception {
 		LOG.debug("<{}.createSchoolGraduationReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/schoolGraduationReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getSchoolGraduationReport(reportRequest);
@@ -402,7 +397,6 @@ public void createSchoolNonGraduationReportException() throws Exception {
 		LOG.debug("<{}.createSchoolNonGraduationReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/schoolNonGraduationReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getSchoolNonGraduationReport(reportRequest);
@@ -457,7 +451,6 @@ public void createStudentNonGradReportException() throws Exception {
 		LOG.debug("<{}.createStudentNonGradReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/studentNonGradReportRequest.json");
 
-		assertNotNull(reportRequest);
 		reportRequest.setData(null);
 
 		apiReportService.getStudentNonGradReport(reportRequest);

diff --git a/...java/ca/bc/gov/educ/grad/report/api/test/service/GradReportApiTranscriptServiceTests.java b/...java/ca/bc/gov/educ/grad/report/api/test/service/GradReportApiTranscriptServiceTests.java
@@ -85,9 +85,6 @@ public void createStudentAchievementReportException() throws Exception {
 		LOG.debug("<{}.createStudentAchievementReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		ReportRequest reportRequest = createReportRequest("json/studentAchievementReportRequest.json");
 
-		assertNotNull(reportRequest);
-		assertNotNull(reportRequest.getData());
-
 		reportRequest.getData().setAccessToken("accessToken");
 
 		mockTraxSchool(adaptTraxSchool(getReportDataSchool(reportRequest.getData())));
@@ -96,10 +93,6 @@ public void createStudentAchievementReportException() throws Exception {
 		String pen = reportRequest.getData().getStudent().getPen().getPen();
 		reportRequest.getOptions().setReportFile(String.format(reportRequest.getOptions().getReportFile(), pen));
 
-		GraduationStudentRecord graduationStudentRecord = mockGraduationStudentRecord(pen, mockGradSearchStudent(pen).getStudentID());
-		assertNotNull(graduationStudentRecord);
-		assertNotNull(graduationStudentRecord.getLastUpdateDate());
-
 		when(apiReportService.getStudentAchievementReportDocument(reportRequest)).thenThrow(new ReportApiServiceException(String.format("Unable to retrieve %s", "getStudentAchievementReport(ReportRequest reportRequest)"), new Exception()));
 		apiReportService.getStudentAchievementReport(reportRequest);
 		LOG.debug(">createStudentAchievementReportException");
@@ -451,20 +444,13 @@ public void createXmlTranscriptReportException() throws Exception {
 		LOG.debug("<{}.createXmlTranscriptReportException at {}", CLASS_NAME, dateFormat.format(new Date()));
 		XmlReportRequest reportRequest = createXmlReportRequest("json/xmlTranscriptReportRequest.json");
 
-		assertNotNull(reportRequest);
-		assertNotNull(reportRequest.getData());
-
 		reportRequest.getData().setAccessToken("accessToken");
 
 		ReportRequestDataThreadLocal.setXmlReportData(reportRequest.getData());
 
 		String pen = reportRequest.getData().getPen().getPen();
 		reportRequest.getOptions().setReportFile(String.format(reportRequest.getOptions().getReportFile(), pen));
 
-		GraduationStudentRecord graduationStudentRecord = mockGraduationStudentRecord(pen, mockGradSearchStudent(pen).getStudentID());
-		assertNotNull(graduationStudentRecord);
-		assertNotNull(graduationStudentRecord.getLastUpdateDate());
-
 		when(apiReportService.getStudentXmlTranscriptReportDocument(reportRequest)).thenThrow(new ReportApiServiceException(String.format("Unable to retrieve %s", "getStudentXmlTranscriptReport(XmlReportRequest reportRequest)"), new Exception()));
 		apiReportService.getStudentXmlTranscriptReport(reportRequest);