-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: use gRPC server config logic from SDK #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzz
changed the title
Refactoring: use gRPC server config logic from SDK
[WIP] Refactoring: use gRPC server config logic from SDK
Nov 21, 2018
Changed to WIP as I'm looking into CI failure. |
bzz
force-pushed
the
refactoring/grpc-opts-from-sdk
branch
from
November 21, 2018 18:59
a0f0ab4
to
7d0a75d
Compare
bzz
changed the title
[WIP] Refactoring: use gRPC server config logic from SDK
Refactoring: use gRPC server config logic from SDK
Nov 21, 2018
Tested and ready for review. CI is expected to be red until all TODO from PR description are not finished. |
juanjux
reviewed
Nov 22, 2018
Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
refactoring/grpc-opts-from-sdk
branch
from
November 22, 2018 13:37
7d0a75d
to
53b2583
Compare
dennwc
requested changes
Nov 22, 2018
This was referenced Nov 22, 2018
Signed-off-by: Alexander Bezzubov <[email protected]>
Review feedback addressed in 4ae7a38, ready for another round. |
dennwc
approved these changes
Nov 23, 2018
creachadair
approved these changes
Nov 23, 2018
Signed-off-by: Alexander Bezzubov <[email protected]>
2 tests are failing on CI 🤔
|
Signed-off-by: Alexander Bezzubov <[email protected]>
juanjux
approved these changes
Nov 27, 2018
Since CI seems to be working I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the bblfsh/client-go#102, migrates to bblfsh/sdk#329
TODOs:
bblfshd
(as soon as as soon as Shared gRPC server config between bblfshd/driver sdk#329 merged and new SDK version is released)v2.8.0 🚀