Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: use gRPC server config logic from SDK #216

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

bzz
Copy link
Contributor

@bzz bzz commented Nov 21, 2018

Part of the bblfsh/client-go#102, migrates to bblfsh/sdk#329

TODOs:

@bzz bzz self-assigned this Nov 21, 2018
@bzz bzz changed the title Refactoring: use gRPC server config logic from SDK [WIP] Refactoring: use gRPC server config logic from SDK Nov 21, 2018
@bzz
Copy link
Contributor Author

bzz commented Nov 21, 2018

Changed to WIP as I'm looking into CI failure.

@bzz bzz force-pushed the refactoring/grpc-opts-from-sdk branch from a0f0ab4 to 7d0a75d Compare November 21, 2018 18:59
@bzz bzz changed the title [WIP] Refactoring: use gRPC server config logic from SDK Refactoring: use gRPC server config logic from SDK Nov 21, 2018
@bzz
Copy link
Contributor Author

bzz commented Nov 21, 2018

Tested and ready for review. CI is expected to be red until all TODO from PR description are not finished.

@bzz bzz force-pushed the refactoring/grpc-opts-from-sdk branch from 7d0a75d to 53b2583 Compare November 22, 2018 13:37
cmd/bblfshd/main.go Outdated Show resolved Hide resolved
@bzz
Copy link
Contributor Author

bzz commented Nov 23, 2018

Review feedback addressed in 4ae7a38, ready for another round.

Signed-off-by: Alexander Bezzubov <[email protected]>
@bzz
Copy link
Contributor Author

bzz commented Nov 27, 2018

2 tests are failing on CI 🤔

--- FAIL: TestDaemonInstallDriver (7.91s)
	Error Trace:	daemon_test.go:42
	Error:		Expected nil, but got: Invalid status code returned when fetching blob 404
		
--- FAIL: TestDriverInstance_State (6.33s)
	Error Trace:	driver_test.go:95
			driver_test.go:47
	Error:		Received unexpected error Invalid status code returned when fetching blob 404
			github.com/bblfsh/bblfshd/vendor/github.com/containers/image/docker.(*dockerImageSource).GetBlob
				/go/src/github.com/bblfsh/bblfshd/vendor/github.com/containers/image/docker/docker_image_src.go:173
			github.com/bblfsh/bblfshd/vendor/github.com/containers/image/image.(*manifestSchema2).ConfigBlob
				/go/src/github.com/bblfsh/bblfshd/vendor/github.com/containers/image/image/docker_schema2.go:107
			github.com/bblfsh/bblfshd/vendor/github.com/containers/image/image.(*manifestSchema2).OCIConfig
				/go/src/github.com/bblfsh/bblfshd/vendor/github.com/containers/image/image/docker_schema2.go:86
			github.com/bblfsh/bblfshd/vendor/github.com/containers/image/image.(*sourcedImage).OCIConfig
				<autogenerated>:1
			github.com/bblfsh/bblfshd/runtime.(*driverImage).WriteTo
				/go/src/github.com/bblfsh/bblfshd/runtime/image.go:80
			github.com/bblfsh/bblfshd/runtime.(*storage).Install
				/go/src/github.com/bblfsh/bblfshd/runtime/storage.go:61
			github.com/bblfsh/bblfshd/runtime.(*Runtime).InstallDriver
				/go/src/github.com/bblfsh/bblfshd/runtime/runtime.go:62
			github.com/bblfsh/bblfshd/daemon.NewRuntime
				/go/src/github.com/bblfsh/bblfshd/daemon/driver_test.go:94
			github.com/bblfsh/bblfshd/daemon.TestDriverInstance_State
				/go/src/github.com/bblfsh/bblfshd/daemon/driver_test.go:47
			testing.tRunner
				/usr/local/go/src/testing/testing.go:777
			runtime.goexit
				/usr/local/go/src/runtime/asm_amd64.s:2361

Signed-off-by: Alexander Bezzubov <[email protected]>
@juanjux
Copy link
Contributor

juanjux commented Nov 27, 2018

Since CI seems to be working I'm merging.

@juanjux juanjux merged commit 6164178 into bblfsh:master Nov 27, 2018
@bzz bzz deleted the refactoring/grpc-opts-from-sdk branch November 27, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants