force resolve multicast-dns v7.2.3 #9133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroebu14
added
the
cross-team
rebeccamcginn
approved these changes
May 26, 2021
added 2 commits
May 26, 2021 09:49
force resolve browserslist v4.16.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
dns-packet has a vuln. webpack-dev-server uses v1 via multicast-dns v6 and the safe version is of dns-packet is 5. Upgrading multicast-dns to v7 introduces a safe version of dns-packet.
This vuln is tracked in webpack-dev-server issue webpack/webpack-dev-server#3340
Same approach taken here:
webpack/webpack-dev-server#3340 (comment)
Code changes:
cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)