Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how we incorporate onward journeys into the navigation #12254

Draft
wants to merge 21 commits into
base: latest
Choose a base branch
from

Conversation

LilyL0u
Copy link
Contributor

@LilyL0u LilyL0u commented Dec 28, 2024

Resolves JIRA [1522]

Spike document:
https://paper.dropbox.com/doc/Spikey-Christmas-Scrollable-OJs-in-nav--CdDX~AodM3ARvL4m68NDDO~tAg-pzr8oSa4ZegneyxTePHAG

Overall changes

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@@ -272,6 +295,11 @@ const ArticlePage = ({ pageData }: { pageData: Article }) => {
{allowAdvertising && (
<AdContainer slotType="leaderboard" adcampaign={adcampaign} />
)}
{!isPGL && !isTC2Asset && variant !== 'none' && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want the OJs to render on TC2 pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant