WSTEAM1-1542: Add live media to header - PRODUCTION #12239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…morgh into WSTEAM1-1521-LIVE-VIDEO-FRONT-END
…morgh into WSTEAM1-1521-LIVE-VIDEO-FRONT-END
…morgh into WSTEAM1-1521-LIVE-VIDEO-FRONT-END
…m/bbc/simorgh into WSTEAM1-1521-LIVE-VIDEO-FRONT-END
…morgh into WSTEAM1-1521-LIVE-VIDEO-FRONT-END
amoore108
reviewed
Jan 6, 2025
amoore108
reviewed
Jan 6, 2025
amoore108
reviewed
Jan 6, 2025
shayneahchoon
changed the title
amoore108
reviewed
Jan 7, 2025
amoore108
reviewed
Jan 7, 2025
| const MemoizedMediaPlayer = memo(MediaLoader); | ||
|
|
||
| const LiveMediaStream = ({ mediaCollection }: Props) => { | ||
| const { translations } = useContext(ServiceContext); |
There was a problem hiding this comment.
Could be worth adding an isLite check here to return null if its Lite. Just so we don't show a button to users that they can't interact with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA WSTEAM1-1521
Resolves JIRA WSTEAM1-1542
Overall changes
VERY IMPORTANT: Production video content will not work on test pages.
Adds live media to the header of a live page:
Adds live tv media to the header of a live page:
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines