Add simorgh to the req-svc-chain header #12236
Draft
+75
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [number]
Overall changes
Adds more information to the req-svc-chain header in Simorgh.
Currently the req-svc-chain for a request to Simorgh is just
GTM,BELFRAGE. This PR updates this toGTM,BELFRAGE,SIMORGHfor requests to the Express & NextJS appCode changes
Testing
Can check headers append locally by using ModHeader to set req-svc-chain header. E.g. setting it to GTM,BELFRAGE or GTM,BELFRAGE,SIMORGH. Can also check in preview/ on test/ on live
Go to an asset. E.g. https://www.bbc.com/afrique/articles/cx2p3273yzvo (Express) or https://www.bbc.com/hindi/live/c4gl10dnpppt (NextJS)
Open developer tools, go to the Network Tab, find the request for the document (may need to refresh)
See req-svc-chain under Response headers.
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines