WSTEAM1-1488: Delete MEDIA_PAGE references #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Dec 6, 2024
Comment on lines
-186
to
-194
| } catch (error: unknown) { | ||
| const { message } = error as Error; | ||
| serviceContext, | ||
| }); | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.error( | ||
| `ATI Event Tracking Error: Could not parse tracking values from page data:\n${message}`, | ||
| ); | ||
| const buildParams = createBuilderFactory( | ||
| requestContext, | ||
| pageTypeParamBuilders, | ||
| ); | ||
|
|
||
| return {}; |
There was a problem hiding this comment.
Hmm maybe I should leave in the error handling just in case something occurs within buildPageATIParams or buildParams
karinathomasbbc
changed the title
Louis-Matsika
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-1488
Overall changes
Deletes all reference to MEDIA_PAGE as it has been separated into AUDIO_PAGE, TV_PAGE & LIVE_RADIO_PAGE
Code changes
Testing
PR checks will catch any issues