Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mundo and Turkce navs: remove US election #12222

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Mundo and Turkce navs: remove US election #12222

merged 2 commits into from
Dec 2, 2024

Conversation

jordit
Copy link
Contributor

@jordit jordit commented Dec 2, 2024

Resolves JIRA n/a

Overall changes

  • Remove US election topic link and CentroAmerica cuenta from Mundo's navigation bar
  • Remove US election topic link from Turkce's navigation bar

Code changes

  • Edited Navigation section of src/app/lib/config/services/mundo.ts
  • Edited Navigation section of src/app/lib/config/services/turkce.ts
  • Updqted snapshots

Testing

  1. Open Mundo front page, Elecciones EE.UU. 2024 should no longer appear as fourth link in the nav and Centroamerica Cuenta should not appear as the last item
  2. Open Turkce's front page, ABD Seçimleri should no longer appear as fourth link in the nav
mundo_nav turkce-nav

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@jordit jordit self-assigned this Dec 2, 2024
@jordit jordit added the cross-team For visibility for both World Service teams (Engage & Media) label Dec 2, 2024
@jordit jordit merged commit 978065e into latest Dec 2, 2024
11 checks passed
@jordit jordit deleted the mundo-turkce-navs-remove-us-election branch December 2, 2024 21:38
@jordit
Copy link
Contributor Author

jordit commented Dec 2, 2024

thanks @karinathomasbbc and @LilyL0u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@LilyL0u LilyL0u LilyL0u approved these changes

Assignees

@jordit jordit

Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordit @LilyL0u @karinathomasbbc