[NASAA-271] Google Discover/Top stories experiment cleanup #12218
Conversation
hotinglok
changed the title
| value: `${experimentVariant}`, | ||
| value: `VARIANT(${ampExperimentName})`, |
There was a problem hiding this comment.
Changed this to not depend on experimentVariant so that it won't clash with any other experiments running that might need this property as well. Should have done this in the first place!
| key: 'mv_experiment_id', | ||
| description: 'AMP experiment name', | ||
| value: `${ampExperimentName}`, | ||
| wrap: false, |
There was a problem hiding this comment.
This ended up being somewhat redundant when we looked at the data. We rarely filtered using this as a column in the Piano dashboard and the mv_test property (shows as MVT - Test in the dashboard properties) is shown by default in the dashboard.
|
|
||
| **Note: This component will not add AMP experiment name/variant information to pageview events. This should be done separately by passing `ampExperimentName` to the `atiData` used.** | ||
|
|
||
| More information about how to use this component/experimentation on AMP can be found here: **TODO: confluence link** |
There was a problem hiding this comment.
I was going to link the documentation here and realised there's no other link or reference to confluence in the codebase. Is it ok to link it here or are there any security concerns (probably just being paranoid 😅).
There was a problem hiding this comment.
I wouldn't bother, we can link to the page via our experimentation documentation
| topStoriesSection: ({ spacings, mq }: Theme) => | ||
| css({ | ||
| marginBottom: `${spacings.TRIPLE}rem`, | ||
|
|
||
| [mq.GROUP_4_MIN_WIDTH]: { | ||
| display: 'block', | ||
| marginBottom: `${spacings.FULL}rem`, | ||
| padding: `${spacings.DOUBLE}rem`, | ||
| }, |
There was a problem hiding this comment.
I've removed the experiment-specific styling added to topStoriesSection here, but this was originally combined with featuresSection as they have the same styles (commit showing this).
Should I combine these together again or keep them separate? We don't have any plans at the moment with either section, but just curious if there was any preference to keep these separate. Happy either way.
There was a problem hiding this comment.
I would say this is fine to keep seperate
Resolves NASAA-271
Overall changes
Removes remaining code specific to the Google Discover/Top Stories experiment. Keeps changes to various analytics functions and the
<AmpExperiment/>component as these can be used for future AMP experiments.Code changes
/experimentTopStoriesfrom/ArticlePage. This contains the majority of the code used solely for the Google Discover/Top Stories experiment.pageViewBeaconValuesin/atiUrl. These are still optional properties that won't be sent unlessampExperimentNameis present, so they won't affect regular usage. Keeping them in as they will most likely be used again in future AMP experiments.<AmpExperiment/>. This component should also remain as it can be used for any future AMP experiments. It is a generic component that accepts anexperimentConfigand ananalyticsConfig. It should/will only be added to pages where/when an AMP experiment will run.Testing
No manual testing is required as regression testing of News/Sport article pages will have been done in the ticket prior to this (#12219).
Ensure all unit/e2e tests pass.
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines