WSTEAMA-1458 - Setup static assets for 2nd preview environment #12215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
approved these changes
Nov 29, 2024
…nment' of github.com:bbc/simorgh into WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
This reverts commit 21355bd.
…review-environment
…nment' of github.com:bbc/simorgh into WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
andrewscfc
requested changes
Dec 5, 2024
andrewscfc
approved these changes
Dec 5, 2024
…review-environment
…review-environment
…nment' of github.com:bbc/simorgh into WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
…review-environment
…nment' of github.com:bbc/simorgh into WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
…review-environment
…review-environment
…nment' of github.com:bbc/simorgh into WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
louisearchibald
deleted the
WSTEAMA-1458-setup-static-assets-for-2nd-preview-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [1458]
Overall changes
Sets up static assets in Simorgh for a secondary preview environment
Code changes
preview.envfile topreview1.env.SIMORGH_PUBLIC_STATIC_ASSETS_PATHto reflect this name change.build:previewto bebuild:preview1& updates the path to .env file in the script body.preview2.envwith theSIMORGH_PUBLIC_STATIC_ASSETS_PATHvalue pointing to this new file.build:preview2command with a path in the script body pointing to the file created above.Testing
Branch was deployed to the preview environment and then tested. The environment was not broken by any of the changes, including the change made in this infrastructure PR. The network tab was inspected for any unexpected 404s (none present), and the new static asset for
preview1is now shown in the header.