-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA-1474 - Move Serbian and Zhongwen to list of migrated services #12212
WSTEAMA-1474 - Move Serbian and Zhongwen to list of migrated services #12212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
Out of interest, if we run Simorgh in production mode for live, what do we see?
yarn build:live && yarn start
If we compare local to the live version of the tipo homepage, are they the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a midnight musing
The E2E tests will fail once this PR reaches the live environment, as it will be trying to run FrontPage tests against the Homepage. We need to disable those tests in this PR completely, and to add one or both of the variant services to the Homepage E2E Tests.
Example of disabled front page test:
frontPage: { environments: undefined, smoke: false }, |
Add an entry for live here:
simorgh/cypress/e2e/pages/homePage/urls.js
Lines 14 to 24 in cbf7c2b
{ | |
service: 'serbian', | |
local: '/serbian/lat', | |
test: '/serbian/lat', | |
}, | |
{ | |
service: 'serbian', | |
local: '/serbian/cyr', | |
test: '/serbian/cyr', | |
}, | |
]; |
Can we also have a look at the lighthouse tests: 🗑️ simorgh/lighthouse/lighthouserc.js Lines 2 to 5 in 114ee50
Add serbian/lat to the live array: simorgh/lighthouse/lighthouserc.js Lines 59 to 65 in 114ee50
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiice! Thanks for making those updates.
@karinathomasbbc Both serbian local pages look identical to the live tipo homepages 🎉 ✅ |
From doing a bit of digging about, it looks like the zhongwen tipo live page had been last updated in May 2024, meaning that it had possibly not been transliterated. I've re-saved it, and I am hoping that it generates the 2 variants behind the scenes 🤞 . Just waiting for the cache to expire and will try again in a few minutes. Otherwise, it could be that these topics won't work until transliteration is live - 5th December? I think we should just re-check those URLs again closer to the release date, just to make sure everything is OK - I imagine that they will updated by Editorial in preparation for going live. |
The date was pushed back by Editorial due to some problems found, so it's now 10th December! Thank you (for this and for your review & comments), I'll make a note on the ticket about re-checking these next week. 🙌 |
…migrated-services
Resolves JIRA [1474]
Overall changes
Adds Serbian & Zhongwen to our list of migrated services in preparation for their upcoming Homepage release (10th Dec).
Code changes
serbian
andzhongwen
tohomePageServices
array.