Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAMA-1474 - Move Serbian and Zhongwen to list of migrated services #12212

Merged

Conversation

louisearchibald
Copy link
Contributor

@louisearchibald louisearchibald commented Nov 27, 2024

Resolves JIRA [1474]

Overall changes

Adds Serbian & Zhongwen to our list of migrated services in preparation for their upcoming Homepage release (10th Dec).

Code changes

  • Adds serbian and zhongwen to homePageServices array.
  • Updates related test.
  • Updates snapshots.

@louisearchibald louisearchibald self-assigned this Nov 27, 2024
@louisearchibald louisearchibald changed the title WSTEAMA-1474 - Move Serbian and Zhongwen to list of migrated services WSTEAMA-1474 - [Do Not Merge] Move Serbian and Zhongwen to list of migrated services Nov 27, 2024
@louisearchibald louisearchibald marked this pull request as ready for review November 27, 2024 16:44
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Out of interest, if we run Simorgh in production mode for live, what do we see?

yarn build:live && yarn start

If we compare local to the live version of the tipo homepage, are they the same?

Local Live (on test environment with renderer_env override)
http://localhost:7080/serbian/cyr https://www.test.bbc.com/serbian/cyr?renderer_env=live
http://localhost:7080/serbian/lat https://www.test.bbc.com/serbian/lat?renderer_env=live
http://localhost:7080/zhongwen/simp https://www.test.bbc.com/zhongwen/simp?renderer_env=live
http://localhost:7080/zhongwen/trad https://www.test.bbc.com/zhongwen/trad?renderer_env=live

Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a midnight musing

The E2E tests will fail once this PR reaches the live environment, as it will be trying to run FrontPage tests against the Homepage. We need to disable those tests in this PR completely, and to add one or both of the variant services to the Homepage E2E Tests.

Example of disabled front page test:

frontPage: { environments: undefined, smoke: false },

Add an entry for live here:

{
service: 'serbian',
local: '/serbian/lat',
test: '/serbian/lat',
},
{
service: 'serbian',
local: '/serbian/cyr',
test: '/serbian/cyr',
},
];

@karinathomasbbc
Copy link
Contributor

Can we also have a look at the lighthouse tests:

🗑️

FRONT_PAGE: {
live: ['https://www.bbc.com/serbian/cyr'],
test: [],
},

Add serbian/lat to the live array:

TIPO_HOME_PAGE: {
live: ['https://www.bbc.com/kyrgyz'],
test: [
'https://www.test.bbc.com/kyrgyz?renderer_env=live',
'https://www.test.bbc.com/serbian/lat?renderer_env=live',
],
},

Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! Thanks for making those updates.

@louisearchibald
Copy link
Contributor Author

louisearchibald commented Nov 28, 2024

LGTM 🥇

Out of interest, if we run Simorgh in production mode for live, what do we see?

yarn build:live && yarn start

If we compare local to the live version of the tipo homepage, are they the same?

Local Live (on test environment with renderer_env override)
http://localhost:7080/serbian/cyr https://www.test.bbc.com/serbian/cyr?renderer_env=live
http://localhost:7080/serbian/lat https://www.test.bbc.com/serbian/lat?renderer_env=live
http://localhost:7080/zhongwen/simp https://www.test.bbc.com/zhongwen/simp?renderer_env=live
http://localhost:7080/zhongwen/trad https://www.test.bbc.com/zhongwen/trad?renderer_env=live

@karinathomasbbc Both serbian local pages look identical to the live tipo homepages 🎉 ✅
However the test zhongwen pages 404? The local ones too so they do match (lol) 😆 but not what I was expecting to see! 🤔

@karinathomasbbc
Copy link
Contributor

karinathomasbbc commented Nov 28, 2024

However the test zhongwen pages 404?

From doing a bit of digging about, it looks like the zhongwen tipo live page had been last updated in May 2024, meaning that it had possibly not been transliterated. I've re-saved it, and I am hoping that it generates the 2 variants behind the scenes 🤞 . Just waiting for the cache to expire and will try again in a few minutes.

Otherwise, it could be that these topics won't work until transliteration is live - 5th December?

I think we should just re-check those URLs again closer to the release date, just to make sure everything is OK - I imagine that they will updated by Editorial in preparation for going live.

@louisearchibald
Copy link
Contributor Author

However the test zhongwen pages 404?

From doing a bit of digging about, it looks like the zhongwen tipo live page had been last updated in May 2024, meaning that it had possibly not been transliterated. I've re-saved it, and I am hoping that it generates the 2 variants behind the scenes 🤞 . Just waiting for the cache to expire and will try again in a few minutes.

Otherwise, it could be that these topics won't work until transliteration is live - 5th December?

I think we should just re-check those URLs again closer to the release date, just to make sure everything is OK - I imagine that they will updated by Editorial in preparation for going live.

The date was pushed back by Editorial due to some problems found, so it's now 10th December! Thank you (for this and for your review & comments), I'll make a note on the ticket about re-checking these next week. 🙌

@holchris holchris changed the title WSTEAMA-1474 - [Do Not Merge] Move Serbian and Zhongwen to list of migrated services WSTEAMA-1474 - Move Serbian and Zhongwen to list of migrated services Dec 10, 2024
@holchris holchris merged commit 204e4cc into latest Dec 10, 2024
11 checks passed
@holchris holchris deleted the WSTEAMA-1474-move-serbian-and-zhongwen-to-migrated-services branch December 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants