WSTEAM1-1461: Fetch On Demand TV data from BFF #12188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke the BFF instead of the JSON endpoint; Implement toggles logic to determine the number of recent episodes to display
… continue to work
This reverts commit f56c4d1.
…AM1-1461-simorgh-fetch-tv-from-bff
…bc/simorgh into WSTEAM1-1461-simorgh-fetch-tv-from-bff
karinathomasbbc
commented
Nov 27, 2024
…AM1-1461-simorgh-fetch-tv-from-bff
karinathomasbbc
changed the title
…AM1-1461-simorgh-fetch-tv-from-bff
HarveyPeachey
approved these changes
Dec 3, 2024
| @@ -58,7 +59,7 @@ const getCampaignID = (pageType: CampaignPageTypes) => { | |||
| [ARTICLE_PAGE]: 'article', | |||
| [MEDIA_ARTICLE_PAGE]: 'article-sfv', | |||
| [FRONT_PAGE]: 'index-home', | |||
| [MEDIA_PAGE]: 'player-episode-tv', | |||
| [MEDIA_PAGE]: 'player-episode', | |||
There was a problem hiding this comment.
was anything actually meant to be player-episode-tv?
There was a problem hiding this comment.
See my comment here: https://paper.dropbox.com/doc/Test-Plan-On-Demand-Audio-TV-and-Live-Radio-pages-anBxRcoM9CiAJNdnkB6I1?t=948328379551413787286778#:t=948328379551413787286778
That said... might it need to be player-episode-tv for ATI when viewing a shared media component such as recent episodes or the radio schedule. Do we need to check with Product before we remove this?
There was a problem hiding this comment.
I guess lug it in with player-episode-tv -> player-episode-radio, as long as they're aware it's changing it should be fine
…AM1-1461-simorgh-fetch-tv-from-bff
Base automatically changed from
WSTEAM1-1347-fetch-ondemand-podcast-from-bff
to
latest
December 4, 2024 09:31
karinathomasbbc
changed the title
karinathomasbbc
changed the base branch from
latest
to
fetch-live-audio-data-on-test
…h-fetch-tv-from-bff
…h-fetch-tv-from-bff
…h-fetch-tv-from-bff
…des displayed is less than or equal to the max limit set in toggles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-1461
Overall changes
Fetch On Demand TV from the BFF instead of from the json endpoint
Code changes
Testing