Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWSWORLDSERVICE-2062: put zhongwen on CPS front page temporarily #12051

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

eagerterrier
Copy link
Contributor

temporary update to see zhongwen solution for optimo

Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the suggestions are reverted (because we don't want to go back to CPS frontpages on test), you should be able to test that the front page URLs have the same variant using:

yarn build:live:debug && yarn start

Then viewing the serbian/zhongwen homepage
http://localhost:7080/zhongwen/simp
http://localhost:7080/zhongwen/trad

src/app/lib/utilities/getStoryPromoInfo/index.jsx Outdated Show resolved Hide resolved
src/app/routes/utils/regex/index.test.js Outdated Show resolved Hide resolved
src/app/routes/utils/regex/utils/index.js Outdated Show resolved Hide resolved
src/app/routes/utils/regex/utils/index.js Outdated Show resolved Hide resolved
src/app/routes/utils/regex/utils/index.js Outdated Show resolved Hide resolved
src/server/local/index.test.js Outdated Show resolved Hide resolved
src/app/lib/utilities/getStoryPromoInfo/index.jsx Outdated Show resolved Hide resolved
@eagerterrier eagerterrier marked this pull request as ready for review October 17, 2024 07:58
@eagerterrier eagerterrier changed the title CHG: put zhongwen on CPS front page temporarily NEWSWORLDSERVICE-2062: put zhongwen on CPS front page temporarily Oct 17, 2024
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eagerterrier eagerterrier merged commit d129612 into latest Oct 17, 2024
11 checks passed
@eagerterrier eagerterrier deleted the features/zhongwen-frontpage-on-test branch October 17, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants