Bump path-to-regexp from 6.3.0 to 8.2.0 #12034
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started trying to work on this. The error is being caused by a change in the way path-to-regexp works so the compile function is erroring. The error you see in the cypress tests is because the variant urls are going to a fallback due to the error from
` try {
const compilePath = compile(path, { encode: value => value });
} catch {
return fallback;
}`
I think the error is because we have characters in the path that are no longer accepted by path-to-regexp. See this screenshot for some detail:
I tried replacing or escaping the invalid characters in the path and made some progress but my stashed changes got lost.
It was also getting quite complex to replace all the characters so the oath could be valid, so I question whether we could instead of using this dependency, do it in a different way. This dependency is only used in this piece of code.
Bumps path-to-regexp from 6.3.0 to 8.2.0.
Release notes
Sourced from path-to-regexp's releases.
... (truncated)
Commits
776c898
8.2.0678756a
Dumb down code for negatee85fe27
Upgrade deps5969033
Target ES201551dbd45
Remove s flag from regexpdf39d6c
Append backtrack, ignore bench in coveraged6c3658
Update express 4 compatibility guidec302644
8.1.07b4598c
Document stringify methodd6150f5
Add pathToRegexp method backYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)