Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSTEAM1-1300 - Article election banner #12024

Merged
merged 91 commits into from
Oct 24, 2024
Merged

WSTEAM1-1300 - Article election banner #12024

merged 91 commits into from
Oct 24, 2024

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Oct 2, 2024 •
edited
Loading

Resolves https://jira.dev.bbc.co.uk/browse/WSTEAM1-1300

Overall changes

  • Adds election banner component to Article pages when certain aboutTags are in the article metadata
  • The election banner component renders a VJ iframe to display the content on both canonical and AMP
  • This is restricted to the Test environment

Note - Design, spacing etc is not yet final

Testing

  1. Visit http://localhost.bbc.com:7080/mundo/articles/c206j730722o?renderer_env=live
  2. Confirm the banner renders above the content
  3. Visit http://localhost.bbc.com:7080/mundo/articles/c206j730722o.amp?renderer_env=live (amp version)
  4. Confirm the banner renders above the content
  5. Visit http://localhost.bbc.com:7080/mundo/articles/c2dp89lgnw7o?renderer_env=live
  6. Confirm the banner does not render as this article doesn't have the correct aboutTags

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

amoore108 added 30 commits April 5, 2024 15:40
@amoore108
WSTEAM1-931 - Article election banner iframe
add88d8
@amoore108
Update index.styles.ts
38f1eb4
@amoore108
Add AMP version
6435289
@amoore108
Service restriction
2a7940d
@amoore108
Update index.tsx
c0c0edd
@amoore108
Use rem for height
4bf885d
@amoore108
Update index.styles.ts
19118e2
@amoore108
Fix storybook to show banner
cad805c
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
33f0169
@amoore108
Set height on container rather than iframe
d442927
@amoore108
Update index.styles.ts
0dd94ca
@amoore108
Find thingLabel from aboutTags
3bc0cc0
@amoore108
Update index.tsx
2f5946f
@amoore108
Make height configurable
325951b
@amoore108
Move config into separate file
046ae8f
@amoore108
Add Storybook story
fc29cd5
@amoore108
Update index.tsx
8a555e2
@amoore108
Rename to iframeSrc
2cef306
@amoore108
Bail out if toggle returns false/null first
1c047b0
@amoore108
Update index.styles.ts
f3b3a40
@amoore108
Construct iframe base url
e86a109
@amoore108
Disable chromatic snapshot for story
2242ae1
@amoore108
Check for service in config rather than iframeSrc
eba6067
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
3778a78
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
8834e30
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
8d18ff8
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
b1eaba8
@amoore108
Add tests and isLive check
d13411f
@amoore108
Merge branch 'latest' into WSTEAM1-931-article-election-banner
af7e7a3
@amoore108
Fix tests
8498358
Isabella-Mitchell
Isabella-Mitchell reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍

@amoore108 amoore108 marked this pull request as ready for review October 23, 2024 10:28
karinathomasbbc
karinathomasbbc reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@karinathomasbbc karinathomasbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like how it has been integrated using the About Tags 👍

src/app/pages/ArticlePage/ElectionBanner/config.ts Outdated Show resolved Hide resolved
src/app/pages/ArticlePage/ElectionBanner/index.tsx Outdated Show resolved Hide resolved
@amoore108 amoore108 merged commit abef9c6 into latest Oct 24, 2024
11 checks passed
@amoore108 amoore108 deleted the WSTEAM1-931-article-election-banner branch October 24, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isabella-Mitchell Isabella-Mitchell Isabella-Mitchell left review comments

@greenc05 greenc05 greenc05 left review comments

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@HarveyPeachey HarveyPeachey HarveyPeachey approved these changes

Assignees

@amoore108 amoore108

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amoore108 @greenc05 @HarveyPeachey @karinathomasbbc @Isabella-Mitchell