Remove node-fetch
#11266
Merged
Remove node-fetch
#11266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d122f4.
amoore108
changed the title
node-fetch""node-fetch
karinathomasbbc
approved these changes
Oct 23, 2024
| const BFF_IS_LOCAL = | ||
| process.env.JEST_WORKER_ID === undefined && | ||
| process?.env?.BFF_PATH?.includes('localhost:3210'); | ||
| const BFF_IS_LOCAL = process?.env?.BFF_PATH?.includes('localhost:3210'); |
There was a problem hiding this comment.
Can this now be removed? BFF_IS_LOCAL is used in an if statement below to determine whether to add optional headers or not, but wondering if we could use certsRequired instead?
There was a problem hiding this comment.
I've updated the logic now to try and make it a bit simpler, inline with your suggestion. a32bff8
It has changed the value of the headers when running locally, but I tested this with the BFF running on the Test env and with the BFF running locally as well and it seems fine?
There was a problem hiding this comment.
Couple more commits to get it working, but think its a bit better? Not sure of the need of the accept header locally, so its removed.
amoore108
added a commit
that referenced
this pull request
Oct 24, 2024
This reverts commit df4043e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11261 and reinstates the original PR: #11122
Description from original PR:
Overall changes
Removes
node-fetchandisomorphic-fetchin favour of using Node 18+ built-in fetch mechanism, provided byundici. Removes the need to do #9611undicihas been added as a dependency as we need itsAgentconstructor to use our custom certs to authenticate requests.This aligns the Express and Next.js app to use the same fetch mechanism across both apps, and removes the need to keep
node-fetchupdated through its transition to ESM.Code changes
node-fetchandisomorphic-fetchand the instances these libraries were importedgetAgentfunction across the Express and Next.js appsAgentandgetAgentin testsfetchDataFromBFFTesting
yarnto install the new dependenciesyarn devrenderer_env=liveflag to ensure it fetches Live data with the certs