Make selectors for event triggers more robust

bbc · Oct 22, 2024 · 6905317 · 6905317
1 parent a7cd6af
commit 6905317
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx b/src/app/pages/ArticlePage/experimentTopStories/helpers.test.tsx
@@ -153,14 +153,14 @@ describe('AMP top stories experiment', () => {
             "trackTopStoriesClick": {
               "on": "click",
               "request": "topStoriesClick",
-              "selector": "[data-testid='promo-link']",
+              "selector": "a[aria-labelledby*='top-stories-promo']",
             },
             "trackTopStoriesView": {
               "on": "visible",
               "request": "topStoriesView",
               "visibilitySpec": {
                 "continuousTimeMin": 200,
-                "selector": "[class*='experimentTopStoriesSection']",
+                "selector": "section[aria-labelledby='top-stories-heading']",
                 "totalTimeMin": 500,
                 "visiblePercentageMin": 20,
               },

diff --git a/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx b/src/app/pages/ArticlePage/experimentTopStories/helpers.tsx
@@ -84,7 +84,7 @@ export const getExperimentAnalyticsConfig = ({
         on: 'visible',
         request: 'topStoriesView',
         visibilitySpec: {
-          selector: `[class*='experimentTopStoriesSection']`,
+          selector: `section[aria-labelledby='top-stories-heading']`,
           visiblePercentageMin: 20,
           totalTimeMin: 500,
           continuousTimeMin: 200,
@@ -93,7 +93,7 @@ export const getExperimentAnalyticsConfig = ({
       trackTopStoriesClick: {
         on: 'click',
         request: 'topStoriesClick',
-        selector: `[data-testid='promo-link']`,
+        selector: `a[aria-labelledby*='top-stories-promo']`,
       },
     },
   };
@@ -193,7 +193,6 @@ export const ExperimentTopStories = ({
     <div
       css={styles.experimentTopStoriesSection}
       data-testid="experiment-top-stories"
-      data-vars-top-stories-position="experiment"
     >
       <TopStoriesSection content={topStoriesContent} />
     </div>