Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just test most recent two releases #271

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Just test most recent two releases #271

merged 1 commit into from
Sep 2, 2017

Conversation

johnynek
Copy link
Member

@johnynek johnynek commented Sep 2, 2017

Testing against HEAD is very brittle and frustrates many new contributors. Until bazel supplies a standard URL to grab the HEAD builds, we should probably rely on the bazel ci bot for HEAD testing.

We still have issue #76 to make more of our tests sh_tests. We have still not tackled them, but if we did, it would probably make the bazel ci bot happier (since they want to just run bazel commands, I think).

cc @damienmg

@ittaiz
Copy link
Member

ittaiz commented Sep 2, 2017

Sounds good but why test a few latest releases?
Mainly asking since we keep moving the needle and I guess we'll require 0.6.0 as the basis very soon.
I suggest to just keep one version until we get a stable HEAD url.

Also,
@damienmg is working on enabling some better bazel e2e testing so once that's in we (Wix) might be able to shift some resources towards #76

@johnynek
Copy link
Member Author

johnynek commented Sep 2, 2017

Not everyone updates immediately. If we can possibly keep a wider range of compatibility, I'd like to.

Honestly, a better approach is something like the oldest version we are compatible with and the newest (even though in between we might still hit intermittent issues).

We are on a pretty old version of bazel and rules_scala now because simply bumping the version caused our builds to break. We didn't see a compelling issue to run it down yet, so we have not. Other users may be in the same boat (note occasionally people report that the latest bazel broke their build).

@ittaiz
Copy link
Member

ittaiz commented Sep 2, 2017 via email

@ittaiz ittaiz merged commit 0609178 into master Sep 2, 2017
@ittaiz ittaiz deleted the oscar/fix-travis branch April 15, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants