Keep bazel from automatically enabling curses with the old sync view #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view.
LeFrosch
force-pushed
the
sync-view-pty-fix-2
branch
from
7953fd0 to
a848bb1
Compare
tpasternak
approved these changes
Dec 10, 2024
github-actions
bot
removed
the
awaiting-review
ujohnny
pushed a commit
to ujohnny/intellij
that referenced
this pull request
Dec 17, 2024
Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view. (cherry picked from commit 2bea8d9)
ujohnny
added a commit
to ujohnny/intellij
that referenced
this pull request
Dec 17, 2024
Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view. (cherry picked from commit 2bea8d9)
mai93
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fixed bug where bazel runs with curses when using the old sync view (#7139) The old sync view does not use a pty based terminal and cannot handle bazel output correctly when it runs with curses. (cherry picked from commit 0fb3f81) * fixed bug where bazel automatically enables curses (#7143) Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view. (cherry picked from commit 2bea8d9) * Do not append `\n` for PROCESS since that output has all of the delimiters and can be chunked not per line. (#7146) (cherry picked from commit f5f8f24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Bazel is invoked using the PtyCommandLine it seems to automatically enable curses. Therefore, to prevent this when using the old sync view this PR adds the explicit --curses=no option.