chore: Remove examples from bazelignore #7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to affect Renovate
github-actions
bot
added
the
awaiting-review
|
Shouldn't we even add more to it (ignore integration testdata) rather that remove it completely? cc @LeFrosch |
|
I'm not sure, but Renovate seems to ignore these directories |
|
@ujohnny Integration test data cannot be ignored since they need to be accessed by the tests at runtime as far as I understand. They are “deleted packages”, see .bazelrc. |
|
So can I remove that, I don't even really see the point of it, while it seems that Revovate fails to upgrade projects there |
sellophane
approved these changes
Dec 11, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to affect Renovate
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change