Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qsync): Handle codegen - generic case #7069

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(qsync): Handle codegen - generic case #7069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions aspect/build_dependencies.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,17 @@ def _collect_own_java_artifacts(
own_gensrc_files.append(java_output.generated_source_jar)
elif java_output.generated_class_jar:
generated_class_jars.append(java_output.generated_class_jar)
else:
for src_attr in JVM_SRC_ATTRS:
# unfortunately, in cases where we have non-cource
# src attribute, we had to add full output jar
# to avoid red code
# We would need jar filtering to handle it well
if hasattr(rule.attr, src_attr):
for src in getattr(rule.attr, src_attr):
for file in src.files.to_list():
if not file.is_source:
generated_class_jars.append(java_output.class_jar)

if generated_class_jars:
own_jar_files += generated_class_jars
Expand Down
Loading