Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small codegen libraries were removed from the Project Structure #7042

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tpasternak
Copy link
Contributor

@tpasternak tpasternak commented Nov 22, 2024

Partially related to #6547

The EmptyJarFilter is using a heuristic that is really not robust

* Any JAR that is this size (in bytes) or smaller is assumed to be empty.
*
* <p>We came up with this number by checking the file size and contents for every JAR in the
* .blaze/libraries directory for several projects (AGSA, AGMM, Express, Photos, Phonesky,
* Memegen, and ASwB). This is the size of the largest empty JAR we saw that is still smaller than
* all of the non-empty JARs we saw.
*/
private static final IntExperiment presumedEmptyThresholdBytes =
new IntExperiment("blaze.empty.jar.threshold", 359);

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@github-actions github-actions bot added product: IntelliJ IntelliJ plugin awaiting-review Awaiting review from Bazel team on PRs labels Nov 22, 2024
@tpasternak tpasternak force-pushed the disable-empty-lib-filter branch from e39e695 to 4aa6f5a Compare November 22, 2024 21:51
@tpasternak tpasternak marked this pull request as draft November 22, 2024 23:21
@tpasternak tpasternak force-pushed the disable-empty-lib-filter branch from 4aa6f5a to 24ce781 Compare November 25, 2024 08:09
@tpasternak tpasternak marked this pull request as ready for review November 25, 2024 08:12
@tpasternak
Copy link
Contributor Author

I already left the bazel org, can you please merge?

@mai93 mai93 merged commit bb32225 into bazelbuild:master Dec 12, 2024
7 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants