fix: Enviroment Variables are not correctly inherited from system on … #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MacOS Use CONSOLE ParentEnvironmentType instead of SYSTEM CONSOLE is the default value initialized in GeneralCommandLineso it was used before. Now, if we want to inherit the system envs we use SYSTEM, so in both cases it differs from what was there before. This PR just brings the old behavior in case a user wants to inherit enviroment from the system. https://github.com/JetBrains/intellij-community/blob/9838665ba816fc8ce06e4071aa5a906a35fbb22e/platform/platform-util-io/src/com/intellij/execution/configurations/GeneralCommandLine.java#L85C1-L86C1 fixes bazelbuild#6163
github-actions
bot
added
product: CLion
blorente
approved these changes
Feb 27, 2024
|
Oh, does it mean the ParentEnvironmentType.SYSTEM was not intentional? That was my only concern |
|
ok if so, I think we can merge and publish a hotfix @mai93 |
|
I would like it to be SYSTEM if the user ticks the "inherit" box, but I agree that right now there's a bug and the this gets people unblocked. I'm happy to iterate on making it work properly later. |
|
Ideally, we'd toggle between SYSTEM and CONSOLE, depending on whether the toggle was clicked or not. |
|
Let's merge and hot fix, I'll iterate in the morning |
github-actions
bot
removed
the
awaiting-review
mai93
pushed a commit
that referenced
this pull request
Feb 27, 2024
…MacOS (#6164) Use CONSOLE ParentEnvironmentType instead of SYSTEM CONSOLE is the default value initialized in GeneralCommandLineso it was used before. Now, if we want to inherit the system envs we use SYSTEM, so in both cases it differs from what was there before. This PR just brings the old behavior in case a user wants to inherit enviroment from the system. https://github.com/JetBrains/intellij-community/blob/9838665ba816fc8ce06e4071aa5a906a35fbb22e/platform/platform-util-io/src/com/intellij/execution/configurations/GeneralCommandLine.java#L85C1-L86C1 fixes #6163
mai93
pushed a commit
that referenced
this pull request
Feb 27, 2024
…MacOS (#6164) Use CONSOLE ParentEnvironmentType instead of SYSTEM CONSOLE is the default value initialized in GeneralCommandLineso it was used before. Now, if we want to inherit the system envs we use SYSTEM, so in both cases it differs from what was there before. This PR just brings the old behavior in case a user wants to inherit enviroment from the system. https://github.com/JetBrains/intellij-community/blob/9838665ba816fc8ce06e4071aa5a906a35fbb22e/platform/platform-util-io/src/com/intellij/execution/configurations/GeneralCommandLine.java#L85C1-L86C1 fixes #6163
|
Sorry, folks, just a question from an outsider here: The issue that was addressed in this PR has made the plugin completely unusable for many developers in my company. Have you considered covering it with some form of tests to ensure it's not reintroduced in the future? |
|
Yep definitely we should :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…MacOS
Use CONSOLE ParentEnvironmentType instead of SYSTEM
CONSOLE is the default value initialized in GeneralCommandLineso it was used before. Now, if we want to inherit the system envs we use SYSTEM, so in both cases it differs from what was there before. This PR just brings the old behavior in case a user wants to inherit enviroment from the system.
https://github.com/JetBrains/intellij-community/blob/9838665ba816fc8ce06e4071aa5a906a35fbb22e/platform/platform-util-io/src/com/intellij/execution/configurations/GeneralCommandLine.java#L85C1-L86C1
fixes #6163
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change