Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress errors from DirectoryToTargetProvider.expandDirectoryTargets #6042

Closed
wants to merge 2 commits into from

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Feb 8, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #5209

Description of this change

Suppresses errors from DirectoryToTargetProvider.expandDirectoryTargets. Since this is only used with childContext.setPropagatesErrors(false) I figured it should be safe to suppress all messages which are published to stderr. This prevents the error messages, which are described in the issue, from being shown to the user.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Feb 8, 2024
@ujohnny
Copy link
Collaborator

ujohnny commented Feb 29, 2024

Not sure if this is a correct fix, we need to investigate for better options.

@LeFrosch
Copy link
Collaborator Author

superseded by #6262

@LeFrosch LeFrosch closed this Mar 18, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Mar 18, 2024
@LeFrosch LeFrosch deleted the Daniel.Brauner/5209 branch August 18, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants