Pass environment variables from BlazeCidrLauncher down to bazel #5771
Conversation
ujohnny
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
ujohnny
force-pushed
the
enovozhilov/env-vars-to-bazel-run-debug
branch
from
ef8d38c to
8b5c0f8
Compare
ujohnny
changed the title
|
checked #2042 description and I think I have to remove the reference to it since environment variables are fixed for C++ targets only. |
BlazeCidrLauncher is aware of environment variables configured in run configuration window. So far it looks like no one just forwarded these variables down to executable process for some unknown reason. fixes bazelbuild#5770
ujohnny
force-pushed
the
enovozhilov/env-vars-to-bazel-run-debug
branch
from
8b5c0f8 to
1b0855f
Compare
github-actions
bot
removed
the
awaiting-review
| @@ -234,11 +241,6 @@ public CidrDebugProcess createDebugProcess(CommandLineState state, XDebugSession | |||
| commandLine.addParameters(handlerState.getExeFlagsState().getFlagsForExternalProcesses()); | |||
| commandLine.addParameters(handlerState.getTestArgs()); | |||
|
|
|||
| EnvironmentVariablesData envState = handlerState.getEnvVarsState().getData(); | |||
There was a problem hiding this comment.
why is it no longer needed for the debug process?
There was a problem hiding this comment.
If I understand correctly, it's been moved to createProcess, which is called later in this method
There was a problem hiding this comment.
I think the call to createProcess is outside the if (!BlazeGDBServerProvider.shouldUseGdbserver()) which returns in line https://github.com/bazelbuild/intellij/pull/5771/files#diff-00e836fdd8bc72a7c8afc8a99218bf627c22fdde6649d55acefc02abe392b990R259
There was a problem hiding this comment.
well I missed this comment as the change was merged and wish I addressed back then. my apologies here.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #5770, #2042
Description of this change
BlazeCidrLauncher is aware of environment variables configured in run configuration window.
So far it looks like no one just forwarded these variables down to executable process for some
unknown reason.
fixes #5770, fixes #2042