Mitigate StartupActivity warnings #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujohnny
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
Since these startup activities do not require indexes we can make them DumbAware and the warning will not be shown. Advised path to migrate them to ProjectActivity is slightly challenging as it requires implementation of Kotlin suspend function in Java code and intellij has issues with bazel plugin indexing in this case. See https://youtrack.jetbrains.com/issue/IDEA-338613 for the details.
ujohnny
force-pushed
the
enovozhilov/sa-warnings
branch
from
7823d49 to
687f8fc
Compare
tpasternak
approved these changes
Nov 29, 2023
github-actions
bot
removed
the
awaiting-review
3 tasks
sgowroji
added a commit
that referenced
this pull request
Dec 6, 2023
* Update CHANGELOG for 2023.12.05 release * Update CHANGELOG with 2 more fixes. * Escape regex-relevant characters in test filter #5745 * Mitigate StartupActivity warnings #5760 --------- Co-authored-by: Gowroji Sunil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change
Since these startup activities do not require indexes we can make them DumbAware and the warning will not be shown. Advised path to migrate them to ProjectActivity is slightly challenging as it requires implementation of Kotlin suspend function in Java code and intellij has issues with bazel plugin indexing in this case. See https://youtrack.jetbrains.com/issue/IDEA-338613 for the details.