feat(ijwb): add environment variables to the run configuration

[JamyDev]

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #2042

Description of this change

This adds the option to set environment variables to your run configuration for any target type. For Test configurations --test_env should be used and thus this field is only shown when set to Run.

Reused the EnvironmentVariablesData that was used in the Python module and applied it everywhere by passing it as an argument to ScopedBlazeProcessHandler, which then passes it onto the ProcessGroup using .withEnvironment.

Since Go handles the Run Configuration differently, we make sure to add the environment variables there as well, in this case as the last one so the user can override variables set elsewhere.

Screenshots:

(this was a go_binary target but I had to modify it for reasons, so it changed it to generic handler)

[tpasternak]

Hey @JamyDev, thank you for this PR! I have two general questions related to the code:

1. I'm not sure if this was intended or not, but contrary to the linked issue Add support for setting Environment Variables via Run Configuration #2042, the java run configuration editor still does not contain the "Environment Variables" field, probably due to the fact that the initializeStates method is overridden in BlazeJavaRunConfigState.
   The implementation in BlazeCommandRunConfigurationCommonState.java has been extended by envVarsState, while BlazeJavaRunConfigState.java remains unchanged

2. I don't fully understand the reason for which the getData() method is guarded by the "is supported command" check?

[mai93]

Please update the comment to match the function return value.

[mai93]

I think it will be simpler to store a boolean of whether the command is supported and check it when needed.

[mai93]

I'm not sure why this method is removed here and in BlazePyRunConfigState.java

[mai93]

Thanks @JamyDev!

I also was not able to see the environment variables for java_binary target run configuration, I'm trying with this example project.

[JamyDev]

Thanks for the comments, I'll address them sometime soon.

[github-actions]

Thank you for contributing to the IntelliJ repository! This pull request has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-review". Please reach out to the triage team (@bazelbuild/triage) if you think this PR is still relevant or you are interested in getting the PR merged.

[github-actions]

This pull request has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!