Address review comments in #6041 pull request

bazelbuild · Feb 15, 2024 · df5fa05 · df5fa05
1 parent 2aff130
commit df5fa05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/clwb/src/com/google/idea/blaze/clwb/run/BlazeCidrRunConfigurationRunner.java b/clwb/src/com/google/idea/blaze/clwb/run/BlazeCidrRunConfigurationRunner.java
@@ -130,7 +130,7 @@ private File getExecutableToDebug(ExecutionEnvironment env) throws ExecutionExce
                       "--copt=-g",
                       "--strip=never",
                       "--dynamic_mode=off"),
-                      BlazeGDBServerProvider.fissionFlag().stream(),
+                      BlazeGDBServerProvider.getOptionalFissionArguments().stream(),
                       extraClangFlags.stream()).collect(Collectors.toList());
         } else {
           extraDebugFlags =

diff --git a/clwb/src/com/google/idea/blaze/clwb/run/BlazeGDBServerProvider.java b/clwb/src/com/google/idea/blaze/clwb/run/BlazeGDBServerProvider.java
@@ -77,7 +77,7 @@ protected String compute() {
 
   // Allows the fission flag to be disabled as workaround for
   // https://github.com/bazelbuild/intellij/issues/5604
-  static ImmutableList<String> fissionFlag() {
+  static ImmutableList<String> getOptionalFissionArguments() {
     if(Registry.is("bazel.clwb.debug.fission.disabled")) {
       return ImmutableList.of();
     } else {
@@ -128,12 +128,12 @@ static ImmutableList<String> getFlagsForDebugging(RunConfigurationState state) {
     }
     if (BlazeCommandName.RUN.equals(commandName)) {
       builder.addAll(EXTRA_FLAGS_FOR_DEBUG_RUN);
-      builder.addAll(fissionFlag());
+      builder.addAll(getOptionalFissionArguments());
       return builder.build();
     }
     if (BlazeCommandName.TEST.equals(commandName)) {
       builder.addAll(EXTRA_FLAGS_FOR_DEBUG_TEST);
-      builder.addAll(fissionFlag());
+      builder.addAll(getOptionalFissionArguments());
       return builder.build();
     }
     return ImmutableList.of();