Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: constrain phonopy and spglib versions #76

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Deps: constrain phonopy and spglib versions #76

merged 1 commit into from
Sep 11, 2024

Conversation

bastonero
Copy link
Owner

Tests fail with recent versions of phonopy and spglib.
From spglib v2.5, some API and functionality have changed,
and phonopy seems to not be functioning as expected
since v2.26 onwards.

Tests fail with recent versions of phonopy and spglib.
From spglib v2.5, some API and functionality have changed,
and phonopy seems to not be functioning as expected
since v2.26 onwards.
@cla-bot cla-bot bot added the cla-signed label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (3ee9e7c) to head (0daaa4c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   87.44%   87.30%   -0.15%     
==========================================
  Files          26       24       -2     
  Lines        2286     2260      -26     
==========================================
- Hits         1999     1973      -26     
  Misses        287      287              
Flag Coverage Δ
pytests 87.30% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastonero bastonero merged commit 3a3e3d1 into main Sep 11, 2024
10 checks passed
@bastonero bastonero deleted the fix/deps branch September 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant