Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clone from each model startup for ComfyUI #146

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

bolasim
Copy link
Contributor

@bolasim bolasim commented Jan 9, 2024

First pass at cleaning up this example. The should probably make it easy to add the models to the cache but will just take it step by step and hopefully invite other people to contribute.

@htrivedi99 would you mind taking a look please? I tested the dev deployment.

@htrivedi99
Copy link
Contributor

looks good to me :)
I ran the truss as well just to make sure everything still works

@bolasim bolasim requested a review from htrivedi99 January 31, 2024 22:14
Copy link
Contributor

@htrivedi99 htrivedi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bolasim bolasim merged commit 0ae36b2 into main Jan 31, 2024
1 check passed
@bolasim bolasim deleted the bola/cleanup-comfy branch January 31, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants