Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JobType model #52

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add JobType model #52

merged 3 commits into from
Jan 11, 2024

Conversation

agus-wesly
Copy link
Contributor

What kind of change does this PR introduce?

Add new model (JobType)

Need to ensure the schema is correct first. Please check to improve.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bandungdev-com ✅ Ready (Inspect) Visit Preview Jan 11, 2024 7:07am

Copy link
Member

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agus-wesly Wait, the field should be jobTypes

// jobs Job[] can be later
jobTypes JobType[]

To resemble the same model name.

@mhaidarhanif mhaidarhanif added the enhancement New feature or request label Jan 11, 2024
Copy link
Member

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, can merge

@mhaidarhanif mhaidarhanif merged commit d3a1fa4 into staging Jan 11, 2024
1 check passed
@mhaidarhanif
Copy link
Member

@agus-wesly Can continue to the rest of the issue requirements: #43

@mhaidarhanif mhaidarhanif deleted the user-profile-job branch January 11, 2024 13:46
@mhaidarhanif
Copy link
Member

@agus-wesly Just realized something significant. jobTypes field should be in UserProfile model. Can fix in the next PR, along with the User Settings to change Job Types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants