fix(Chart): weaken visibility dependency to series

bamlab · Jan 26, 2024 · a6f5443 · a6f5443
1 parent aa40d71
commit a6f5443
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/core/web-reporter-ui/src/components/Charts/Chart.tsx b/packages/core/web-reporter-ui/src/components/Charts/Chart.tsx
@@ -103,6 +103,8 @@ export const Chart = ({
   const chartOptions = useMemo(() => merge(commonOptions, options), [commonOptions, options]);
 
   const ref = useRef<ReactApexChart>(null);
+  const seriesRef = useRef(series);
+  seriesRef.current = series;
 
   useEffect(() => {
     //@ts-expect-error chart is not defined in the typings, but it exists!
@@ -111,10 +113,10 @@ export const Chart = ({
 
     toggleSeriesVisibility(
       chart,
-      series.map((serie) => serie.name).filter((name): name is string => !!name),
+      seriesRef.current.map((serie) => serie.name).filter((name): name is string => !!name),
       visibleSeriesNames
     );
-  }, [series, visibleSeriesNames]);
+  }, [visibleSeriesNames]);
 
   return (
     <ReactApexChart ref={ref} options={chartOptions} series={series} type={type} height={height} />