Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filters #91

Merged
merged 4 commits into from
Oct 22, 2024
Merged

fix: Filters #91

merged 4 commits into from
Oct 22, 2024

Conversation

garethfuller
Copy link
Contributor

We were re-initializing query state in all the filter components. This PR ensures the query state hook is only initialized once in the pool list provider and then access through the provider everywhere else.

The re-use of the hook in many places was starting to cause issues like here: https://www.loom.com/share/56577edf6c864e0480314a15c4666250

@garethfuller garethfuller requested a review from agualis October 22, 2024 08:59
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-beets-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:35pm
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:35pm
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 3:35pm

@garethfuller garethfuller changed the title fix: Only init querystate once fix: Filters Oct 22, 2024
@garethfuller garethfuller merged commit 3634805 into main Oct 22, 2024
8 checks passed
@garethfuller garethfuller deleted the refactor/query-state-usage branch October 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants